haganbmj
0/0 Germ
Posts: 13 
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Jul 31, 2022 0:59:35 GMT
Wanted to share an MSE fork with some additional changes on top of v2.1.2. github.com/haganbmj/MagicSetEditor2/releasesAs of July 30, 2022 those changes include... - Correct unicode text entry behavior to permit typing non-Latin characters.
- Add filter boxes to Game/Stylesheet lists.
- Independently control Export Zoom setting in Preferences Window.
- Load Image Slice Window with some window size constraints.
- Add centering options to Image Slice Window
- Add ability to underline text.
- Add ability to internally store images at >100% scale. Only useful if you intend to export at >100% scale.
- extra_card and extra_card_style scripting variables to access properties for stylesheet defined fields.
- Fix storage/retrieval of Stylesheet Settings when the stylesheet name includes spaces.
If anyone else has changes they've made in their local copy of MSE I'd love to add them.
TranslationsAdditionally, I had noticed that non-English translations hadn't been updated since probably 2.0.0. If anyone wants to help take a stab at updating the locale files for another language I've gone ahead and included the most recent files and appended any missing keys that need translating. Those files can be found here: github.com/haganbmj/MagicSetEditor2/tree/master/dataIf you see a #_ADD prefix to a line this indicates something that isn't present in the language file, there are also a few spots where English was used that could use correction. Indentation is important with MSE Locale files. They explicitly want tab characters rather than spaces, and you'll see instances where the locale defines keyboard shortcuts. In the below example "menu" indicates a parent key, and the keys below it require indentation. So when defining a new value for "save set as a directory" it's important to match the indent. (It's humorous that these forums are stripping the formatting from my code block examples...)
menu:
save set as: 名前をつけて保存... F12
#_ADD save set as directory: Save As Directory...
|
|
haganbmj
0/0 Germ
Posts: 13
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Aug 2, 2022 22:33:02 GMT
Thanks to GenevensiS for the French translations. | Language | Status |
|---|
| French | Up to Date | | S-Chinese | Partial | | T-Chinese | Partial | | Danish | Partial | | German | Partial | | Spanish | Up to Date | | Italian | Partial | | Japanese | Partial | | Polish | Partial | | Brazilian Portuguese | Partial |
|
|
Hâlian
0/0 Germ
.
Posts: 14
Favorite Card: Marwyn, the Nurturer
Favorite Set: Future Sight
Color Alignment: Green
|
Post by Hâlian on Aug 13, 2022 2:59:38 GMT
|
|
|
|
Post by nachoman on Aug 13, 2022 16:38:11 GMT
Hi, thanks for this version, the additions are amazing  By the way, I'm having this issues: 1) The custom export size always return to 100% no matter what 2) Even if the "Use viewer rotation settings when export" is checked, the export size is always 100% 2) If the zoom level is changed and then changed back to 100%, the set symbol remains in the previous size for some reason (but is fixed restarted the program) 3) In the Statistics tab, it seems like the keywords uses count is not working for custom keywords (the count for standard keywords is fine) I hope this keeps growing and improving |
|
haganbmj
0/0 Germ
Posts: 13
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Aug 15, 2022 14:32:14 GMT
Hi, thanks for this version, the additions are amazing By the way, I'm having this issues: 1) The custom export size always return to 100% no matter what 2) Even if the "Use viewer rotation settings when export" is checked, the export size is always 100% 2) If the zoom level is changed and then changed back to 100%, the set symbol remains in the previous size for some reason (but is fixed restarted the program) 3) In the Statistics tab, it seems like the keywords uses count is not working for custom keywords (the count for standard keywords is fine) I hope this keeps growing and improving 1. Export Size works the same as any other preference - are you seeing similar behavior when trying to change any of those? That might indicate some failure to store the settings - which are in %AppData%\Magic Set Editor if I'm remembering correctly off hand. 2a. "Use Viewer Rotation" is only going to apply to rotation now, so that's intentional. 2b. That's bizarre. I'll see if I can replicate it. 3. I'll have a look at keyword count; any idea if that's pre-existing in 2.1.2 or earlier versions? |
|
haganbmj
0/0 Germ
Posts: 13
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Aug 15, 2022 18:40:35 GMT
Actually, both Zoom and Export Zoom are stored at the stylesheet setting level. If you open back a set with the same stylesheet is the export zoom the same? github.com/haganbmj/MagicSetEditor2/blob/4a606474c423bdf4d67e87b58f391fefdb58ed84/src/data/settings.cpp#L123-L132That whole behavior is a bit wonky, I was looking at adding Zoom to the toolbar, but determining what to scope to the stylesheet, game, or program level is awkward. EDIT: And looking at the Keyword Statistics I'm seeing them all grouped together under "Custom". I can take a look at an enhancement to support charting custom keywords, but that looks to be pre-existing and working as expected at least.  |
|
|
|
Post by nachoman on Aug 16, 2022 4:42:26 GMT
Hi, thanks for this version, the additions are amazing By the way, I'm having this issues: 1) The custom export size always return to 100% no matter what 2) Even if the "Use viewer rotation settings when export" is checked, the export size is always 100% 2) If the zoom level is changed and then changed back to 100%, the set symbol remains in the previous size for some reason (but is fixed restarted the program) 3) In the Statistics tab, it seems like the keywords uses count is not working for custom keywords (the count for standard keywords is fine) I hope this keeps growing and improving 1. Export Size works the same as any other preference - are you seeing similar behavior when trying to change any of those? That might indicate some failure to store the settings - which are in %AppData%\Magic Set Editor if I'm remembering correctly off hand. 2a. "Use Viewer Rotation" is only going to apply to rotation now, so that's intentional. 2b. That's bizarre. I'll see if I can replicate it. 3. I'll have a look at keyword count; any idea if that's pre-existing in 2.1.2 or earlier versions? Hi, thanks for the reply 1) I find the config file in "AppData\Roaming\Magic Set Editor": there was two files: "mse.config" and "mse8.config" (is it normal to have two config files?). I look inside "mse.config" and manually change the "export_zoom" and now it's working... But the Export zoom is then locked with the new value and I need change it manually in the config file because in the Preferences keeps resettig to the value in the config file. Is not perfect, but I can live with that 2a) Sorry, I was confused because the other MSE has the "use ZOOM and rotation when exporting" thing, there's nothing wrong with the rotation, my problem was the export size. 2b) Try changing the zoom level to 200% and then change back to 100%. That's how I get the problem, but is fixed when I close and reopen the set file. 3) I check again and the keyword counting it's working perfectly. But for some reason it wasn't working that time, I don't know why. |
|
haganbmj
0/0 Germ
Posts: 13
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Aug 16, 2022 17:07:48 GMT
1. I'm really not sure what's going on with your preference file, it shouldn't be resetting itself like that unless it's somehow failing to save the file? It would be mse.config though.
2b. The set symbol works as expected for me, which is where I'm trying to figure out what's causing it to do that for you.
3. Glad the keyword counting is working, if I find the opportunity I'll see about what it would take to individually chart custom keywords though - not a super high priority though.
|
|
|
|
Post by nachoman on Aug 18, 2022 0:57:57 GMT
1. I'm really not sure what's going on with your preference file, it shouldn't be resetting itself like that unless it's somehow failing to save the file? It would be mse.config though. 2b. The set symbol works as expected for me, which is where I'm trying to figure out what's causing it to do that for you. 3. Glad the keyword counting is working, if I find the opportunity I'll see about what it would take to individually chart custom keywords though - not a super high priority though. I delete the MSE folder in %AppData and try again, but the issues remain. But if this is just happening to me, then the problem is something in my pc, not the MSE. At least I discover how to deal with it and is not too serious. By the way, im curious about if in the future would it be possible 1) import/export set as csv or spreadsheet and 2) a dark mode (not sure if this is possible, but I'm curious). Also, I tried to update the spanish translation. I make a rush edit, so I need check it later in search of errors and missing translations, but I wanted shared anyways to know your opinion: locale.txt (33.87 KB) |
|
haganbmj
0/0 Germ
Posts: 13
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Aug 18, 2022 15:08:05 GMT
Awesome, thanks for the translations. I'll run through and double check the formatting and get those added.
Dark Mode is unlikely - MSE uses wxWidgets and that library has basically abandoned the effort on Windows due to compatibility issues so anything would have to be fully custom.
|
|
|
|
Post by nachoman on Aug 21, 2022 15:17:42 GMT
Awesome, thanks for the translations. I'll run through and double check the formatting and get those added. Dark Mode is unlikely - MSE uses wxWidgets and that library has basically abandoned the effort on Windows due to compatibility issues so anything would have to be fully custom. No, thanks to you and your work I checked again the translation and fixed some things (accent marks, missing translations and a little edit to some words): locale.txt (34.37 KB). About the dark mode, is understandable and thanks for the info. What about import/export spreadsheets? I'm not pressing or demanding, i'm just curious. |
|
|
|
Post by twintania on Aug 28, 2022 8:15:42 GMT
I'll try Japanese translation later.
Now I am holding a tournament with my card set so I am busy.
I will need to ask some questions about translation.
Where can I ask it? This thread?
|
|
haganbmj
0/0 Germ
Posts: 13
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Aug 31, 2022 0:08:43 GMT
Awesome, thanks for the translations. I'll run through and double check the formatting and get those added. Dark Mode is unlikely - MSE uses wxWidgets and that library has basically abandoned the effort on Windows due to compatibility issues so anything would have to be fully custom. No, thanks to you and your work I checked again the translation and fixed some things (accent marks, missing translations and a little edit to some words): View Attachment. About the dark mode, is understandable and thanks for the info. What about import/export spreadsheets? I'm not pressing or demanding, i'm just curious. Sorry, caught COVID and was out for a bit. I've added the Spanish translations - thanks again! I need to read more into Import/Export - The existing export options all rely on custom scripting so it's a bit awkward to figure out what importing should look like. I'll try Japanese translation later. Now I am holding a tournament with my card set so I am busy. I will need to ask some questions about translation. Where can I ask it? This thread? Good luck with your tournament! This thread would be fine. Here is the existing Japanese translation as a starting point. raw.githubusercontent.com/haganbmj/MagicSetEditor2/master/data/jp.mse-locale/locale |
|
|
|
Post by twintania on Sept 23, 2022 20:39:08 GMT
haganbmjNow I am starting it and have some questions. - At first, is this spacing has something important?
It is very unreadable.
I want to align like this below.
file: &ファイル
new set: &新規作成... Ctrl+N
open set: &開く... Ctrl+O - Is there way to insert comment in the middle of line like // or /**/ in C ?
- What is the deference between &-starting words and ones without &?
- Is there a document about locale file syntax which answers these questions?
- Opening mse with this locale and then card notes area flickers eternally and console prints mass of "Missing key in locale: collapse notes".
Is only way to stop this flicker that fill all words with translations?
|
|
haganbmj
0/0 Germ
Posts: 13
Favorite Card: Wirewood Symbiote
|
Post by haganbmj on Nov 19, 2022 1:52:21 GMT
These files are custom, as is the meaning behind their formatting and special characters - so it's a bit tricky to figure out.
- The spacing shouldn't be important.
- You can insert comments by using the # sign.
- The & signs are for keyboard shortcuts using Alt, though they're probably not commonly used and probably not well assigned anyways so it might be better to just leave them off.
- No documentation, I've had to dig through the source code to figure anything out.
- I think it should report a missing locale entry once, but yes the only option is to have everything available. I can remove "#_ADD" when packaging the locale files to give any untranslated lines an English value as a fallback so that should be avoidable.
|
|
